[ECP-9878] Authorize the payment upon the API response handling#3260
[ECP-9878] Authorize the payment upon the API response handling#3260candemiralp wants to merge 10 commits intodevelop-11from
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant refactoring of the payment authorization flow within the Adyen module. The primary goal is to centralize and standardize how payments are authorized, whether initiated by webhooks or direct API responses. By introducing a dedicated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and beneficial refactoring by creating a central AuthorizationHandler to manage payment authorization logic. This change improves code structure by consolidating logic that was previously distributed across various helpers, and it decouples components from the Notification object. While the overall direction is positive, I have identified a couple of important issues. There appears to be a regression where functionality for handling overpaid and underpaid Boleto payments has been removed. Additionally, the new AuthorizeAfterOrderPlacement observer contains some unsafe array accesses that could lead to errors. I've added specific comments with suggestions to address these points.
|



Description
This PR allows payment authorization after completing
/paymentsor/payments/detailscall immediately if theresultCode: Authorised.The logic in the
AuthorizationWebhookHandlerstill exists and acts as a fallback.With this implementation, order state is moved to
processingoradyen_authorizedbased on the capture mode immediately.Tested scenarios